Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(datepicker): avoid accidental form submissions through calendar buttons #10515

Merged
merged 1 commit into from
Apr 6, 2018
Merged

fix(datepicker): avoid accidental form submissions through calendar buttons #10515

merged 1 commit into from
Apr 6, 2018

Conversation

crisbeto
Copy link
Member

Sets all internal calendar buttons to be type="button" in order to avoid accidental submissions if the calendar is placed inside a form.

Fixes #10514.

@crisbeto crisbeto requested a review from mmalerba as a code owner March 21, 2018 18:55
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 21, 2018
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed pr: needs review labels Mar 21, 2018
@josephperrott
Copy link
Member

@crisbeto please rebase

@crisbeto
fix(datepicker): avoid accidental form submissions through calendar b…
112be4a 
…uttons

Sets all internal calendar buttons to be `type="button"` in order to avoid accidental submissions if the calendar is placed inside a form.

Fixes angular#10514.
@crisbeto
Copy link
Member Author

Rebased.

@crisbeto crisbeto force-pushed the 10514/calendar-button-types branch from b47cc47 to 112be4a Compare March 27, 2018 22:35
@jelbourn jelbourn merged commit edb57f9 into angular:master Apr 6, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add type="button" to controls in mat-calendar
5 participants
@crisbeto @josephperrott @mmalerba @jelbourn @googlebot